Closed synopss closed 1 year ago
Is it okay if I push changes directly into your branch? You made the PR from the main branch so it's a little awkward when the main branch is tied up to a PR, but if you're not going to do anything else with the branch it should be fine.
Fine for me.
Found a few issues:
As you said, it's a PoC so it's good to have as a jumping off point, but I cannot merge it without fixing all of these issues.
I'll fix some of these so that I can start trying it out. I think background colors could help, but I want to run it across a few people before I commit to having the feature at all, or maybe having it as an option; if neither, it could always be implemented as a separate addon plugin (or a completely independent plugin).
Fixes : #14
Notes :
TextAttributes
is seen as a deprecated way to do things,TextAttributesKey
should be used instead. I didn't use it to keep things close to the existing code base.