change_key_generation_logic

[takuabonn]

Overview

• https://github.com/cia-labs/Storage-service/issues/28

implement contents

create key generator

• Each time key is generated, (key+1) of the current table is added as a string

create table which save generated key

test case

• Does it work thread-safe?
• Whether to return 0 when there is nothing in the initial table

[takuabonn]

hi, @Tejas-ChandraShekarRaju I am sory. Since pytest is not in requirements.txt So far in my environment, I get bash: pytest: command not found I have been using python -m unittest tests/key_generator_test.py instead.

[Tejas-ChandraShekarRaju]

hi, @Tejas-ChandraShekarRaju I am sory. Since pytest is not in requirements.txt So far in my environment, I get bash: pytest: command not found I have been using python -m unittest tests/key_generator_test.py instead.

Pytest should come preinstalled with python 3.10 and above if im not wrong

[takuabonn]

hi, @Tejas-ChandraShekarRaju Run pip install pytest, Try pytest.

[Tejas-ChandraShekarRaju]

hi, @Tejas-ChandraShekarRaju Run pip install pytest, Try pytest.

I don't have to. I'm asking if your tests are running with pytest? If yes can you add a screen shot here? Both tests.py and key_generator_tests.py

[takuabonn]

hi, @Tejas-ChandraShekarRaju I run it with only the following command python -munittesttests/key_generator_test.py

I did not run it with pytest.

[takuabonn]

hi, @Tejas-ChandraShekarRaju Running pytest tests/test.py on the main branch does not It fails as well. Do I need to create the tables before running tests/test.py?

[Tejas-ChandraShekarRaju]

hi, @Tejas-ChandraShekarRaju Running pytest tests/test.py on the main branch does not It fails as well. Do I need to create the tables before running tests/test.py?

No You don't have to

[takuabonn]

hi, @Tejas-ChandraShekarRaju Why does test.py fail in my environment even before the modification? If the main branch also fails, it has nothing to do with this fix.

[Tejas-ChandraShekarRaju]

hi, @Tejas-ChandraShekarRaju Why does test.py fail in my environment even before the modification? If the main branch also fails, it has nothing to do with this fix.

Hey, We'll have to verify that. Will check in sometime

[takuabonn]

hi, @Tejas-ChandraShekarRaju Does it fail in your environment as well?

[Tejas-ChandraShekarRaju]

hi, @Tejas-ChandraShekarRaju Does it fail in your environment as well?

Hey. It isn't failing. I will approve the workflow run. Let's see if it goes through.

[Tejas-ChandraShekarRaju]

Hi @takuabonn . We are good to go, Your branch is just one commit behind, Can you consume that as well?

[takuabonn]

hi, @Tejas-ChandraShekarRaju The changes were incorporated into the branch.