search

ciena-frost / ember-frost-core

http://ciena-frost.github.io/ember-frost-core/
MIT License
18 stars 42 forks source link

fix the ugly frost-theme and frost-app scss import requirement #234

Open rox163 opened 8 years ago

rox163 commented 8 years ago

From Ember slack discussion regarding easily importing one addons stylesheets into another addon. Works great only for an app, not addon.

nathanhammond [1:53 PM] @rox163 Confirmed, is an issue. Check out ember-cli-eyeglass which has a resolution story for that.

rox163 [1:54 PM] ah cool. will do. thanks @nathanhammond

nathanhammond [1:54 PM]
It's actually a tremendously difficult problem to solve, and the solutions out there aren't flawless.

nathanhammond [2:05 PM] @rox163 Most of the CSS work in Ember CLI was done without a lot of plans. My work right now is to extract that from Ember CLI and turn it into an addon. Once done (in a completely backwards-compatible manner) then we can iterate toward a better CSS/Sass solution. (Which will probably look like continuous incremental improvement to ember-cli-eyeglass)

dafortin commented 8 years ago

Interesting !

sglanzer-deprecated commented 8 years ago

I was talking to @job13er about this problem the other day, we'll need to do some analysis of options in the LTS.2 timeframe. The other option I'm currently considering is a full shift to PostCSS, but we need a clearer idea of what that would entail.

rox163 commented 8 years ago

The current 1.0.0 solution is not the best but allows for a nice import of styles for consuming apps '@import ember-frost-core/frost-theme' Styles that need to be exposed for easy imports are in app/styles/ember-frost-core, in addition to the normal /addon/styles location. These files would need to stay in sync with each other.