ciena-frost / ember-frost-object-browser

See all of your objects! http://ciena-frost.github.io/ember-frost-object-browser/
MIT License
5 stars 22 forks source link

Add more... button #161

Closed gkchestertron closed 6 years ago

gkchestertron commented 6 years ago

This project uses semver, please check the scope of this pr:

Closes #87

CHANGELOG

gkchestertron commented 6 years ago

20pjmrgr8s

look good John, we noticed a small discrepancy with Style Guide as follows:

screen_shot_2018-01-10_at_10_57_50_am

notmessenger commented 6 years ago

I understand that the action bar is intended to work with frost-button components and it is the component we use within the Frost ecosystem but I'm not sure I like the idea of looking for that component type specifically. By doing so we force the usage to require frost-button rather than only needing to be passed a component. Even if we take such "meta" support off the table for this discussion how does this code hold up if an application has extended the frost-button component and is using it instead?

notmessenger commented 6 years ago

Please create an issue indicating that the Ember 2.8-specific introduced in this PR can be removed once no longer supporting Ember 2.8

gkchestertron commented 6 years ago

@notmessenger, your comment about being specific to frost-button is a good point. I was specifically trying to avoid wrapping up links or other dropdowns because this feature is for wrapping up actions. Perhaps I could generalize it to components that have and onClick property.

notmessenger commented 6 years ago

That might be an interesting approach to the problem

notmessenger commented 6 years ago

👍

Approved with PullApprove

notmessenger commented 6 years ago

👍

Approved with PullApprove