Closed quincyle closed 7 years ago
Could you update the changelog section in the PR description with a summarized list of changes?
Should we use Ember.typeOf instead of typeof
?
@dafortin - My vote is yes, use Ember.typeOf. It will return the same result across all browsers and includes a bit more detail. Here is what will be returned: http://emberjs.com/api/#method_typeOf
| Return Value | Meaning |
|---------------|------------------------------------------------------|
| 'string' | String primitive or String object. |
| 'number' | Number primitive or Number object. |
| 'boolean' | Boolean primitive or Boolean object. |
| 'null' | Null value |
| 'undefined' | Undefined value |
| 'function' | A function |
| 'array' | An instance of Array |
| 'regexp' | An instance of RegExp |
| 'date' | An instance of Date |
| 'class' | An Ember class (created using Ember.Object.extend()) |
| 'instance' | An Ember object instance |
| 'error' | An instance of the Error object |
| 'object' | A JavaScript object not inheriting from Ember.Object |
versus the Javascript typeof
: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/typeof
Undefined "undefined"
Null "object" (see below)
Boolean "boolean"
Number "number"
String "string"
Symbol (new in ECMAScript 2015) "symbol"
Host object (provided by the JS environment) Implementation-dependent
Function object (implements [[Call]] in ECMA-262 terms) "function"
Any other object "object"
Agreed with @juwara0 - prefer Ember.typeOf
@quincyle given the size and impact of this review I would like a scheduled formal review to be done. Please book 2-3 hours and confirm participation from at least 3 other team members. The participants should read through this code ahead of time and come prepared with notes.
we may need a bithoundrc file for this repo to ignore all the snippet files that are reported as failures in bithound's lint
This project uses semver, please check the scope of this pr:
CHANGELOG
Resigned entire object browser.
Removed support for block slot format API.
Removed frost-object-browser-inline API.
Removed support for build in ember-frost-info-bar.
Added data-driven API.
Added component helper based full access API.
Added object-browser-mixin.
Added object-browser-route-mixin.
Added object-browser-serializer as data layer.
Added build in support for query binding, pagination with data-driven API.
Added build in support for server/client sorting and filtering with data-driven API.
Added live demo and documentations.
Updated object browser layout.
Updated ember and ember-cli to 2.8.
Updated ember-frost-core to 1.x.x.
Updated ember-frost-bunsen to 12.x.x.
Updated ember-frost-list to 3.x.x.