cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.99k stars 258 forks source link

Fix emoji ordering #2057

Open marekvospel opened 1 week ago

marekvospel commented 1 week ago

Description

When using emojis in cinny I noticed the order of emojis and stickers being the same as the order I uploaded them. Later when inviting my friends to the room, they showed me, that their order of emojis is different. (across homeservers) image
image

This PR aims to fix this by ordering the emotes alphabetically (which feels like the most logical way to order them) both in emoji picker and inside autocomplete.

Fixes #1632

Type of change

Checklist:

github-actions[bot] commented 1 week ago

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

marekvospel commented 1 week ago

I have read the CLA Document and I hereby sign the CLA

github-actions[bot] commented 1 week ago

Preview: https://2057--pr-cinny.netlify.app ⚠️ Exercise caution. Use test accounts. ⚠️

marekvospel commented 15 hours ago

Overall LGTM.

I think it doesn't fix #1632 specifically as it sort the the search result alphabetically rather than how well they match with the query as per request. For example searching fire result in list containing heart_on_fire , firefighter which should be sorted based on the index of fire, result word-size and does fire is on the word boundary.

True, I'll update the description to be more precise.