cioraneanu / firefly-pico

A delightful Firefly III companion web app for effortless transaction tracking
GNU Affero General Public License v3.0
317 stars 15 forks source link

[Bug] Save button hidden by bottom buttoms after scrolling. #90

Closed captainrex493 closed 1 week ago

captainrex493 commented 1 month ago

On any menu with a save button, if the page is scrolled down, the save button goes behind the bottom buttons. Scrolling up does not cause the button to reappear. thumbnail2

cioraneanu commented 1 month ago

What OS and browser is that? Does the problem persist in other browsers?

captainrex493 commented 1 month ago

The OS is Android 14 on a Pixel 7. The browser is Firefox v128.0.3. It also happens when using chrome. Screenshot_20240803-121503.png

avee87 commented 1 month ago

I have an opposite issue on iOS sometimes - Save button stays in the middle of the screen obscuring other controls. Admittedly, it only seems to happen when keyboard is up. IMG_9384C51432FC-1

cioraneanu commented 1 month ago

@captainrex493 I've managed to reproduce the issue on Firefox. Will look into it.

cioraneanu commented 1 month ago

@avee87 That's the default behaviour of iOS (it annoys me as well πŸ˜‡ ). If you have the keyboard hidden, and tap an input in the bottom of the screen, the browser attempts to avoid having the input covered by CSS position: fixed elements so it moves them.

Would love to have a solution for this as well :)

cioraneanu commented 1 month ago

@captainrex493 pushed a fix. Give the :dev docker tag a try and let me know if it's working as expected for you.

@avee87 handling the fixed button position while the keyboard is visible seems tricky :D i’ve played with the values provided by the Visual Viewport API but it’s not perfect; there seems to be some sort of offset that is missing.

captainrex493 commented 1 month ago

The dev branch seems to work as expected.

cioraneanu commented 1 month ago

@avee87 1 million trial + errors later πŸ˜„ ... I think I've reached a decent solution to have the button react to the keyboard changes / input positions. Give the dev branch a shot. πŸ˜‡