search

circleinteractive / uk.co.circleinteractive.offlinerecurring

Offline Recurring Payment Extension for CiviCRM
0 stars 4 forks source link

Editing recurring payment crashes in Civi 5.68+ #4

Open MegaphoneJon opened 8 months ago

MegaphoneJon commented 8 months ago

Attempting to edit an offline recurring contribution in CiviCRM 5.68+ results in this error:

Error: Call to private method CRM_Contribute_Form_Contribution_Main::buildRecur() from scope CRM_OfflineRecurring_Form_RecurringContribution in CRM_OfflineRecurring_Form_RecurringContribution->buildQuickForm() (line 122 of /home/jon/local/mysite/web/sites/all/civicrm-custom/extensions/uk.co.circleinteractive.offlinerecurring/CRM/OfflineRecurring/Form/RecurringContribution.php)

CRM_Contribute_Form_Contribution_Main::buildRecur() is a private method in Civi 5.69+, and doesn't take an argument.

I know this hasn't received an update for a looong time but I thought someone else might need to see this.

I don't currently expect to fix this, but if I do, I'll update this ticket.

pradpnayak commented 8 months ago

Hi @MegaphoneJon

I have a forked version(https://github.com/pradpnayak/uk.co.circleinteractive.offlinerecurring/tree/UpgradeExtension) where I fixed the function at the start of this year. Can you please test?

Thanks Pradeep

MegaphoneJon commented 7 months ago

@pradpnayak I'll have this in production by the end of the week.

eptbertram commented 6 months ago

Dear @pradpnayak , your fork is working on Civi 5.70 (with Drupal 10). Thank you very much! And I like to thank @MegaphoneJon , too. This feature is a very good tool to collect member fees for a German association.

pradpnayak commented 6 months ago

Hi @eptbertram

Thank you for doing the test.