Fix Travis CI builds & drop Python 2.6 support

circus-tent / circus

A Process & Socket Manager built with zmq

http://circus.readthedocs.org/

Other

1.55k stars 258 forks source link

Fix Travis CI builds & drop Python 2.6 support #1110

Closed sphuber closed 4 years ago

sphuber commented 4 years ago

While addressing issue #1099 I found that the CI builds on Travis were severely broken. I took the liberty to fix them which consisted of moving to Xenial to get the required python versions and addressing various flake8 messages. I dropped 2.6 because it is difficult to install and it has been EOL for over 5 years.

coveralls commented 4 years ago

Coverage remained the same at ?% when pulling b987b5cd9acd2e80ee654a1cd39294ea27729be0 on sphuber:fix_travis_builds into da45a601001954082ed270d130922d9ce46b983c on circus-tent:master.

coveralls commented 4 years ago

Coverage remained the same at ?% when pulling b987b5cd9acd2e80ee654a1cd39294ea27729be0 on sphuber:fix_travis_builds into da45a601001954082ed270d130922d9ce46b983c on circus-tent:master.

sphuber commented 4 years ago

It was originally being run as a separate job on py2.7 but I moved it to run at the end for all jobs. Just in case there are python version specific code paths. This build for example didn't have an actual difference but the next does. Seey other PR. You can also looking at the end of one of jobs in the build to see that it actually run. I can put it back as a separate step he way it was before if you prefer.

sphuber commented 4 years ago

@k4nar let me know if you'd like me to revert the coveralls change. Once this is merged, I can rebase PR #1111 which will fix a quite blocking problem for a lot of people.

k4nar commented 4 years ago

Thank you very much for taking the time to do this!

sphuber commented 4 years ago

You are very much welcome, thanks for merging. With this merged PR #1111 is now ready for review as well.