cisagov / ScubaGoggles

SCuBA Secure Configuration Baselines and assessment tool for Google Workspace
https://www.cisa.gov/resources-tools/services/secure-cloud-business-applications-scuba-project
Creative Commons Zero v1.0 Universal
164 stars 22 forks source link

Criticality for GWS.COMMONCONTROLS.10.2v0.3 in all caps in rego #457

Open adhilto opened 1 month ago

adhilto commented 1 month ago

🐛 Summary

Super minor cosmetic thing, but the criticality for the "no relevant event" case is in all caps, when for consistency, it should be "Shall."

    "Criticality": "SHALL",

Note that this does not prevent ScubaGoggles from running correctly.

To reproduce

Run ScubaGoggles, note that if there are no events for this control, the criticality shows up as "SHALL" in the HTML report.

Expected behavior

The criticality to show up as "Shall."

Any helpful log output or screenshots

image