cisagov / cool-assessment-terraform

Terraform to deploy an assessment environment to the COOL
Creative Commons Zero v1.0 Universal
13 stars 4 forks source link

Support multiple email-sending domains per assessment #127

Closed dav3r closed 2 years ago

dav3r commented 3 years ago

💡 Summary

Enable an assessment to have more than one email-sending domain.

Motivation and context

Some types of assessments require multiple instances (e.g. Teamservers), where each instance sends email from a different domain. Currently, our email_sending_domain variable only supports a single domain.

Implementation notes

Convert the email_sending_domain variable from a string to a list.

Acceptance criteria

jsf9k commented 3 years ago

As part of this work, please update the description for the email_sending_domain variable to make it clear that the FQDN is expected.

dav3r commented 3 years ago

According to @kyleevers, multiple email-sending domains are almost never used in a single RPT environment, so implementing this feature is not as important as previously thought.