cisagov / manage.get.gov

A Django-based domain name registrar used by the .gov domain to communicate with an EPP registry
https://get.gov
Other
58 stars 18 forks source link

Org Member Page - Three dots/ellipsis Buttons #2764

Open therealslimhsiehdy opened 1 week ago

therealslimhsiehdy commented 1 week ago

Issue description

Focusing on the Action buttons for the row expansion on the Org Member page

Acceptance criteria

Additional context

Refinement questions:

  1. Do we want to prioritize having a cancel status (allows Analyst to see what state it is in)?
  2. Does "in progress" mean anything that is not approved or rejected?
  3. Are we missing a "view" of when we're about to remove a manager, who would be the last domain manager/sole domain manager that is left for a domain?

Links to other issues

h-m-f-t commented 3 days ago

@gabydisarli @AnnaGingle Can you take a look at the questions above and respond?

gabydisarli commented 3 days ago
  1. Do we want to prioritize having a cancel status (allows Analyst to see what state it is in)? Can you add more clarity here? I'm not following
  2. Does "in progress" mean anything that is not approved or rejected? Yes and I think we should not include Withdrawn as well. So in progress means anything Started, In review, Action needed
  3. Are we missing a "view" of when we're about to remove a manager, who would be the last domain manager/sole domain manager that is left for a domain? Can you add more clarity here? I'm not following
abroddrick commented 1 day ago

@gabydisarli for 1: This is not a blocking question on the ticket, it is more of a consideration for product on prioritization. We are adding in a cancel feature which makes multiple users in the same org able to cancel people's invitations. Adding in a cancel status on invitations would allow us to track invitations that have been canceled. There was a request for domain invitations to have this on django admin. Thus coupled with the knowledge that we want an audit log in the future, makes me think we should just go ahead and work in the invitation status of "canceled" into the model for domain invitation and portfolios. I would love people's thoughts here, but, to be clear, even if we did this it wouldn't be included in this ticket anyways.

Are we missing a "view" of when we're about to remove a manager, who would be the last domain manager/sole domain manager that is left for a domain? Can you add more clarity here? I'm not following Picture is better, we have these: image The view I am referring to is one in which someone is the only domain manager. In the pic there is a alert mocked up for the last admin and has in progress request, but not "you can't remove this person because there is no other domain manager"

AnnaGingle commented 5 hours ago
  1. Are we missing a "view" of when we're about to remove a manager, who would be the last domain manager/sole domain manager that is left for a domain?

I don't think we need a separate design for each alert so I track them in the annotations right next to the design. This is the annotation, so no that is not missing. Card

AnnaGingle commented 5 hours ago
  1. Do we want to prioritize having a cancel status (allows Analyst to see what state it is in)?

This cancel invitation button isn't new, it exists on the domain managers page in the app today. Would a canceled status be helpful to them?