Handle null auth_results - Githubissues

cisagov / trustymail_reporter

Generate Trustworthy Email reports based on scan data

Creative Commons Zero v1.0 Universal

10 stars 4 forks source link

Handle null auth_results #42

Closed jsf9k closed 3 years ago

jsf9k commented 3 years ago

🗣 Description

This pull request makes two small changes in order to gracefully handle the case where auth_results is None.

💭 Motivation and context

There is at least one such record in the DMARC database, even though the DMARC schema states that there must be at least one entry in the auth_results list.

🧪 Testing

I have done several full reporting runs with these changes.

✅ Checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

jsf9k commented 3 years ago

It does the thing! It would be nice to have an issue and a comment to track the schema's failure to validate as we expect.

See cisagov/dmarc-import#8.