simple fix to make supported versions also normalize grease values

cisco / mercury

Mercury: network metadata capture and analysis

Other

437 stars 75 forks source link

Closed ToryQuinn closed 4 years ago

ToryQuinn commented 4 years ago

Noticed that the supported versions grease values weren't normalizing

Supported Version portion of the fingerprint before this PR: Screen Shot 2020-06-17 at 4 45 06 PM

After: Screen Shot 2020-06-17 at 4 45 55 PM

This is due to b'002b' != '002b'

Not sure if this behavior is different across different OS or python versions Screen Shot 2020-06-17 at 4 47 13 PM

banderson84 commented 4 years ago

Thank you again! I think this was a latent bug from when I switched from Python2 to Python3.

ToryQuinn commented 4 years ago

np :) These fixes were the easy part, thanks for doing the heavy lifting and putting this whole thing together.