search

citation-style-language / csl-editor

cslEditorLib - A HTML 5 library for searching and editing CSL styles
http://editor.citationstyles.org
MIT License
187 stars 34 forks source link

For dependent styles: Clicking "edit" does nothing #191

Open leejones-san opened 8 years ago

leejones-san commented 8 years ago

When I open a style and click "edit", nothing happens. This issue recurs on Firefox, Chrome and IE.

zuphilip commented 8 years ago

What do you mean exactly?

I see the menu showing Undo and Redo under Edit:

edit-click

leejones-san commented 8 years ago

Apologies for being unclear. I mean when I click the button highlighted here (or the "edit style" button after clicking "view style"), nothing happens. The button does not work.

untitled

zuphilip commented 8 years ago

Well, the edit normally works. However, the style you are trying to edit is a dependent style and the same as some more general Taylor & Francis style. If you click on the link after "same as" then you should be able to edit this parent style.

However, it seems that edit link for dependent style should be either deactivated or linked to the parent style. @adam3smith

[fixed typo, AS]

bschilder commented 3 years ago

@zuphilip, would it not be better to provide some indicator to users that these entries are not editable?

Some potential ways to do this:

  1. Remove or disable the Edit button for these entries and replace it with a note indicating the restrictions.
  2. Enable Edit for these entries, but create copy with an autogenerated unique ID (eg by adding a number to the original entry's name).
  3. Provide a pop up message upon clicking Edit , warning users they can't actually edit.

Option 2 would probably be my preferred choice, because it lets users edit the CSL files (which is what users will be expecting from CSL Editor) while preserving the integrity of the (vetted?) dependent styles.