search

citusdata / citus

Distributed PostgreSQL as an extension
https://www.citusdata.com
GNU Affero General Public License v3.0
10.59k stars 671 forks source link

Tests are not using hll or other extensions #3888

Open SaitTalhaNisanci opened 4 years ago

SaitTalhaNisanci commented 4 years ago

Currently in our tests on CI, we are not using hll or other extensions because they are not installed and there is an alternative input for tests that require hll or topn or tdigest. This also means the code coverage is not what we expect. We should make sure that tests pass with extensions installed locally and then update the test images so that they have the necessary extensions installed.

onderkalaci commented 4 years ago

This sounds like a relatively important item to fix. I almost never install hll or topn locally assuming that they'll run on CI. Given that most of us keep recreating the dev environments/databases, I wouldn't be surprised if majority of the devs in a similar situation with me.

@SaitTalhaNisanci is the fix involved or a quick one? Any initial thought?

SaitTalhaNisanci commented 4 years ago

If the docker images in our the-process repository can be built without a problem, this might be a simple thing to do ( only adding the extensions and recreating the docker images and pushing them would be enough).

If the docker images cannot be built because there are some outdated things, then it might be more involving.

thanodnl commented 4 years ago

Lets add tdigest to the list of extensions to add.