city96 / ComfyUI_ExtraModels

Support for miscellaneous image models. Currently supports: DiT, PixArt, HunYuanDiT, MiaoBi, and a few VAEs.
Apache License 2.0
394 stars 35 forks source link

In hunyuan, can now generate 1280x768, but it's cropped #54

Closed festivus37 closed 6 months ago

festivus37 commented 6 months ago

Hi, thanks for your great work integrating what chaojie started with these hunyuan nodes. I've been using theirs until I just saw that you updated yours. You can now generate in 1280x768, but it's just cropped 1024x1024. If you look at the difference between theirs and yours, they've got a node that specifies a resolution on the checkpoint loader as well. You need the resolution in both the empty latent AND the checkpoint loader so that it doesn't just still do 1024x1024 and crops the image. An example prompt that will cut off the head if not done correctly at 1280x768 is the following. Thanks very much for your work on this. The prompt: Anime-style illustration featuring a muscular cyborg character with glowing eyes, mechanical arms and tubes, highlighted in fiery orange and contrasting deep shadows, standing powerfully with large machinery in the background, sharp lines, and dynamic shading enhancing the intensity and futuristic atmosphere.

city96 commented 6 months ago

Thank you very much for the report. I've tracked down the issue and have fixed it (I think).

There is a "HYDiTSrcSizeCond" node that can be used to replicate the original "cropped" behavior as well, but it is not required for normal usage.

Could you please test it again?

festivus37 commented 6 months ago

Hi, unfortunately it's still cropped. I uninstalled anything I had previous and did a git clone of the repo url. doing a git pull inside the dir says already up to date (just making sure I have the latest files. I'm attaching a screenshot. Screenshot 2024-05-27 at 11 20 11 PM Screenshot 2024-05-27 at 11 22 02 PM

city96 commented 6 months ago

Wait, I'm stupid, I had the width/height the wrong way around which is why it seemed "cropped". Now it really should be 1:1 to the original if you update. Hopefully.

image

festivus37 commented 6 months ago

image Yep, we're in good shape now. Thanks again for getting this worked out.

city96 commented 6 months ago

No problem, sorry for missing the real issue the first time around lol