search

civicrm / org.civicrm.flexmailer

FlexMailer is now part of civicrm-core. Please see the link below for how to upgrade.
https://civicrm.org/extensions/flexmailer
Other
5 stars 22 forks source link

autogenerate the plain text version after token substitution #20

Open michaelmcandrew opened 6 years ago

michaelmcandrew commented 6 years ago

This PR alters DefaultComposer as follows:

Only create a body_text (text/plain)message for TokenProcessor if body_text has been specified. If it has not bee specified, set$autoGeneratePlainText` to true for DefaultComposer so we know to auto generate the plain text version later on

Once any token substitution and link tracking has happened, if no plain text version has been specified, run the generated HTML through CRM_Utils_String::htmlToText to create a plain text version of the email.

See associated PR on civicrm-core for more details.

seamuslee001 commented 6 years ago

@michaelmcandrew just a few failures https://test.civicrm.org/job/CiviCRM-FlexMailer-PR/13/ :-)

michaelmcandrew commented 6 years ago

jenkins test this please

michaelmcandrew commented 6 years ago

Once the tests pass here, I should ask tim to review https://github.com/civicrm/civicrm-core/pull/12061

michaelmcandrew commented 6 years ago

jenkins test this please now that https://github.com/civicrm/civicrm-core/pull/12026/files has been merged

michaelmcandrew commented 6 years ago

see full discussion in https://lab.civicrm.org/dev/mail/issues/3

mlutfy commented 4 years ago

jenkins, test this please

mlutfy commented 4 years ago

Tests seem to be passing? https://test.civicrm.org/job/Extension-SHA/749/console

@michaelmcandrew Have you been running this patch for the past 2 years? Is there anything that you might think could be blocking a merge? (I won't merge it, but I can try to get another merger to review it)