civicrm / org.civicrm.shoreditch

Other
44 stars 59 forks source link

SearchKit layout problems #554

Open niels-heinemann opened 1 year ago

niels-heinemann commented 1 year ago

Hey folks, we are experiencing some design problems with bootstrap/shoreditch on latest civicrm. Any ideas how to fix/what may be the reason? form-builder-filters

For example, searchkit's submit button is inaccessible. I had to trigger the click event in developer console. searchkit

PS: There are some others things in shoreditch's mattermost channel!

mlutfy commented 1 year ago

@niels-heinemann Which CMS are you using? We have a fork here that works well with d7/d9/wp: https://github.com/coopsymbiotic/shoreditch (for wp, also requires this extension: https://civicrm.org/extensions/shoreditch-wordpress)

niels-heinemann commented 1 year ago

Dude, that would be fantastic! We're using d7.

mlutfy commented 1 year ago

If you use Seven as the civicrm admin theme, it should work (including with this version from Compuco)

If not, try the symbiotic fork, it's a drop-in replacement that is pretty close to upstream, but fixes a few things : https://github.com/coopsymbiotic/shoreditch/archive/refs/heads/symbiotic.zip

niels-heinemann commented 1 year ago

We use bootstrap in civi, so no seven. I'll try the replacement.

niels-heinemann commented 1 year ago

grafik No real change :-(

jamienovick commented 1 year ago

Hi @niels-heinemann This might be a search kit problem and not a Shoreditch problem. Shoreditch provides CSS but not the teamplates. Please can you file an issue there and make it clear which versions of CiviCRM, Shoreditch, Drupal etc you are using. Best

mlutfy commented 1 year ago

We use bootstrap in civi, so no seven. I'll try the replacement.

Shoreditch only works with Seven. (edit: shoreditch includes a copy of bootstrap)

jamienovick commented 1 year ago

Hey both,

I don't want to confuse things but perhaps we are talking about 2 different things.

Firstly, when installing Shoreditch CiviCRM theme, it only styles within the CiviCRM container. It is possible however that a Drupal theme could impact on the Shoreditch theme as it can theme inside the CiviCRM container also.

As such we created a D7 admin theme for CiviCRM specific pages called the Shoreditch companion Drupal theme:

https://github.com/compucorp/shoreditch-companion-d7-theme

You should instal this theme and set it as the default CiviCRM administrator theme in your Drupal theme settings. Then follow the other installation instructions and remove any other blocks from the page not needed.

In any case this might not solve your problem if actually the latest version of search kit in some way is not fully compatible with Shoreditch and in which case I would recommend submitting an issue for the github queue for search kit.

niels-heinemann commented 1 year ago

Dear @jamienovick , thx a load for your hints but we use the companion theme and shoreditch a long time successfully. It's just that we have design issues with some of the new extensions like search kit, search action designer and such. Maybe simply because the developing folks do not use Shoreditch. However I've worked around this problems for a long time, so I do not think, the developers will address this soon.