search

cjfields / Bio-Tools-Primer3Redux

A reimplementation of BioPerl's Primer3-related code for primer3 v1 and v2
http://bioperl.org
10 stars 5 forks source link

primer3v2 feature integration and additional tests #5

Closed fschwach closed 13 years ago

fschwach commented 13 years ago

I have added tests for the newly added features -p3_settings_file and EQUENCE_PRIMER_PAIR_OK_REGION_LIST. There is now and array of tests which provide test conditions and expectations so that more tests can be added more easily. The drawback fo that is that it can be a bit tricky to update the number of tests in the plan but it will be easier to add additional tests for more parameters if we want to. I have also fixed an issue with get_processed_seq raised by cassj and a problem with priemr3 v1.x related to the count of primers rturned. I guess the question is to what extend it is even desirable to keep supporting v1.x given that 2.x has been around for quite a while now? Let me know what you think. Cheers, Frank

cjfields commented 13 years ago

I merged the two sets of tests, everything passes on my end. thanks!