search

ckan / ckanext-googleanalytics

CKAN extension to integrate Google Analytics data into CKAN. Gives download stats on package pages, list of most popular packages, etc.
GNU Affero General Public License v3.0
35 stars 81 forks source link

Extension adds "?_ga=..." parameters to all external links #30

Closed jakubklimek closed 7 years ago

jakubklimek commented 7 years ago

When googleanalytics is enabled in CKAN 2.6.1 (not tested with other versions), it adds parameters like ?_ga=1.259127497.2133035748.1425991248 to all outgoing external links (like in the footer) on mouse up event. It does not do this for links that go back to the same instance (like to datasets or organizations).

If the target of the external link processes HTTP GET parameters, it gets confused by this. I have not found a switch to turn this off.

gleb-rudenko commented 7 years ago

I'll take a look at it

jakubklimek commented 7 years ago

Seems working OK after the patch. Should be closed?

smotornyuk commented 7 years ago

Thanks. Same for me, just wanted to receive someone's other verification:)