Open MandanaMoshref opened 1 year ago
@MandanaMoshref thanks for the report. Can you tell if it's an issue with the repeating subfields javascript or with the way the form page is rendering? If you come up with a fix please submit a PR.
@MandanaMoshref thanks for the report. Can you tell if it's an issue with the repeating subfields javascript or with the way the form page is rendering? If you come up with a fix please submit a PR.
@wardi from my understanding it is related to the form page. I studied the behavior of view.py and found another strange behavior.
Regarding Edit: def edit
causes the editing problematic. commenting out the if h.scheming_get_dataset_form_pages(package_type): seems to solve the problem for editing the Schemata with and without form_pages. I just did some clicking tests.
One more error is related to creating a new dataset with form pages. Creating the package and being in the last stage (resource creation), if the user decides to go back by clicking the previous button, it starts from page 1 (default by ckan) in edit mode which is OK. The problem is clicking next and from form page 2 it shifts to new and does not stay in edit mode causing all repeating_subfields to be removed and appear empty.
These are just my assumptions. Cannot say it for sure as I am not familiar with the code. For example, I do not understand that it is only the problem with lists like repeating_subfields and not a simple added text field.
in summary, i guess the form_page still needs more testing and therefore, it is better to be mentioned in the readme, that at the moment for complex attributes, required, etc. it cannot be used.
using form pages repeating_subfields causes inconsistency. While adding a new resource works perfectly, for editing the resource, it does not work for those fields with repeating_subfields. The main problem is that the repeating subfields only take the initial value (can be also empty) and after editing the new values do not update.
to reproduce the error: ckan version: 2.10 ckanext-scheming: latest (installed on 01.07.2023) scheming.yml -> Try to add one organization and date when creating a new dataset, and then edit these same fields with a new organization and date