search

ckeditor / ckbuilder

The development repository of CKBuilder, a command line builder for CKEditor 4.
Other
19 stars 11 forks source link

Various plugin folders stripped of files #26

Closed gblair closed 5 years ago

gblair commented 5 years ago

I've been trying to use this on the ckeditor-dev (v4.11.x) repo, and noticed that, for plugins, the plugin.js, lang, and others in a given plugin directory are destroyed after the build is completed (this appears to be during the second "cleaning up target folder" phase, in deleteUnusedFiles().

It looks, from the code, like this is expected behavior. I can't help but think, then, that I might subsequently be including my built library into my project in an invalid way. When including (the subsequently built) CKEditor in my project, eventually, it tries to load (over HTTP) the lang.js from the plugin, and does not find it (because it was deleted during the build process, and is not present in the built library folder). Is this the expected behavior? Any tips or ideas about what I'm doing wrong would be so much appreciated 🙇.

gblair commented 5 years ago

Errr... never mind -- I think I figured out my little problem here. The way I was including the built library in my project (using copy-webpack-plugin) I had neglected to include the consolidated lang/*.js file(s). With that available, the individual plugin files are not needed, it seems. Thanks again.