search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Template js doesn't work after CKEditor enable/disable. #219

Closed armang98 closed 3 years ago

armang98 commented 3 years ago

Type of report

Bug

Provide detailed reproduction steps (if any)

In my template I was integrate editor, and I have logic that user can enable/disable editor, after disable editor template's tab navigation doesn't work. Video: https://user-images.githubusercontent.com/37144283/133139868-445a64af-b5c1-4cdd-b82a-bab2dd1c8d2d.mp4

Description of video: At the start editor is enabled (places where there are dashed lines these are editable areas, and editor can work), and I do not click any area and just disable editor, after that I click on tabs and they works, but after I again enable editor, click on of tabs, editor starts working, and again I do not change anything, just activate editor on this tab area, and after again disable editor and after that when I click on tabs they do not work, it's strange because in Inspect element I see that nothing changed in html part also (e.g. deleting any attribute or something like this).

P.S. If I do click on other area (not on tab) editors activate and after that disable editor, tabs works perfectly, I'm getting this issue only in case when I do click on tab navigation area.

Expected result

Expecting that editor will not affect in template js file.

Other details

jacekbogdanski commented 3 years ago

@armang98 could you provide a minimal editor demo allowing to reproduce the issue using one of the tools linked in the issue report template?

It's hard to tell which part of the editor integration may not work well looking just at the video recording from your application.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this issue as stale due to inactivity. Please provide the requested feedback or the issue will be closed after next 7 days.

armang98 commented 3 years ago

@jacekbogdanski I share my little project on my github, here is link, it's works correctly like in my shared video. Let me know if you have any help or any question! And if you find any mistake in my code you can commit changes freely. Thanks!

jacekbogdanski commented 3 years ago

@armang98 I'm sorry but:

If you have CKEditor license, please contact our support team, so we can help with debugging your application. Otherwise, please use the minimal editor demo requested in https://github.com/ckeditor/ckeditor4/issues/4881#issuecomment-919085553

armang98 commented 3 years ago

@jacekbogdanski I'm very apologize about private repository. And it will be really great to review my application. I just provide a little project with this error case, will be great if you take a look into this. Thank you!

armang98 commented 3 years ago

@jacekbogdanski here is example in the stackblitz minimal editor. https://stackblitz.com/edit/angular-minimal-medium-editor-example-owkegm

jacekbogdanski commented 3 years ago

Issues for angular integration should be reported in https://github.com/ckeditor/ckeditor4-angular

I will transfer this ticket to the correct repo. @MMMalik could I ask you to take a look at this issue?

MMMalik commented 3 years ago

Hello @armang98,

Thank you for your effort in providing the sample. The first thing I noticed is that you are not using our official ckeditor4-angular integration. My suggestion is that you give it a try.

Moreover, the issues you are experiencing are most likely not related to CKEditor 4 and are quite possibly related to the way how you manage state of your tabs.

This being said, please note that our GitHub issue tracker serves for reporting bugs and new features only. Unfortunately, your request is neither of them, therefore please leave your question on Stack Overflow where our team and the community assist other users in solving their issues. Also, since CKEditor is an Open Source software, we believe it’s crucial to share proposed solutions and make others benefit from them.

If you have CKEditor license, please contact our support team. You also can ask your implementation questions at Stack Overflow.

armang98 commented 3 years ago

Hi @MMMalik , I have published my question on Stack Overflow and I hope your team will help me to get solution of this, and I'm almost sure that it's editor's bug because I have tried many way to manage state of my tabs(pure js, jquery, other tab navigation libs.. ) and no one way works in this case. Stack Overflow link: https://stackoverflow.com/questions/69426746/template-js-doesnt-work-after-ckeditor-enable-disable