search

ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.8k stars 2.48k forks source link

Investigate Safari selection API changes #4885

Open sculpt0r opened 3 years ago

sculpt0r commented 3 years ago

Type of report

Task

Provide description of the task

Failing tests:

passed on older Safari version (like 14.0.1) but failing on newest (14.1) on the same CKEditor build. We discover that earlier Safari versions behave differently (https://github.com/ckeditor/ckeditor4/issues/4689#issuecomment-901823866). However, it is hard to reproduce such a difference on casual websites using selection API from the console. Investigation details are in comments under #4689

If we will be able to reproduce different behaviour in a generic case - we will be able to report this issue in a WebKit bug tracker.

Other details

jacekbogdanski commented 3 years ago

Let's ignore #4689 and #4693 on Safari, so these tests are not breaking CI or testing phase. Remember about the note: Ignored due to #4885, so we can fix these tests later once this issue is investigated.

sculpt0r commented 2 years ago

Let's find out if those tests are still failing in even the newest version of Safari. If not - lets re enable tests.