search

clEsperanto / pyclesperanto

GPU-accelerated Image Processing library using OpenCL
https://clesperanto.github.io/pyclesperanto
BSD 3-Clause "New" or "Revised" License
31 stars 6 forks source link

Wrong funcgtion signature for power() #271

Closed haesleinhuepf closed 1 month ago

haesleinhuepf commented 1 month ago

In _interoperability.py, we should change the order of parameters and renamed of the power function. It should be power(x1, out, x2) instead of power(x1, x2, out=None). Furthermore, we should rename "x1" to "input_image", "out" to "output_image" and "x2" to "exponent".

haesleinhuepf commented 1 month ago

Just for reference: https://github.com/clEsperanto/pyclesperanto_prototype/blob/8bd12efd32d2bcdbfc859bcfec85c7a567e17b06/pyclesperanto_prototype/_tier1/_power.py#L6

haesleinhuepf commented 1 month ago

And not this is different from power_images: https://github.com/clEsperanto/pyclesperanto_prototype/blob/8bd12efd32d2bcdbfc859bcfec85c7a567e17b06/pyclesperanto_prototype/_tier1/_power_images.py#L6

haesleinhuepf commented 1 month ago

We should remove power from _interoperability.py