clEsperanto / pyclesperanto

GPU-accelerated Image Processing library using OpenCL
https://clesperanto.github.io/pyclesperanto
BSD 3-Clause "New" or "Revised" License
31 stars 6 forks source link

remove numpy style function #274

Closed StRigaud closed 1 month ago

StRigaud commented 1 month ago

closes #267 closes #271

I removed the numpy style clip which was overwritting clesperanto clip.

The other function numpy in interoperability does not overwrite their equivalent clesperanto, should we still remove them?

StRigaud commented 1 month ago

@haesleinhuepf I removed all numpy style function from interroperability file and updated the tests.

Can you confirme this is ok? I will merge this today along the next release

haesleinhuepf commented 1 month ago

Yes, that makes sense @StRigaud! Let's think about compatibility with numpy later :-)

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.96%. Comparing base (2f51de2) to head (f391cc5).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #274 +/- ## ========================================== + Coverage 87.91% 87.96% +0.05% ========================================== Files 20 20 Lines 1646 1604 -42 ========================================== - Hits 1447 1411 -36 + Misses 199 193 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.