search

clMathLibraries / clBLAS

a software library containing BLAS functions written in OpenCL
Apache License 2.0
839 stars 240 forks source link

Only estimate kernel source size if we actually have the kernel source #24

Closed gicmo closed 10 years ago

gicmo commented 10 years ago

See issue #21 for the discussion why this seems necessary under OSX.

kknox commented 10 years ago

Go ahead and squash these two commits together; they are small. I'll take a good look tonight.

Off the cuff, i think this is a good patch to get tests working on the Mac platform, but I wonder about why it fails in the first place. The API works flawlessly in Linux and Windows, so I am suspicious of what is happening on Mac. I am attempting to get our Mac team to investigate in parallel.

gicmo commented 10 years ago

I squashed the two commits.

I also agree that this seems more like a workaround a bug in the OpenCL implementation, which should just return zero if there is no source attached to a cl_program (like the bug in clGetProgramInfo of pocl [1]). Maybe if you (and the Mac team) agree we should open a bug at Apple's bug tracker.

[1] http://www.mail-archive.com/pocl-devel@lists.sourceforge.net/msg00414.html

kknox commented 10 years ago

closes #21