Install scripts/perf to share/clBLAS on non WIN32 systems

[marbre]

Python scripts should not get installed to /usr/bin. Same as for clFFT https://github.com/clMathLibraries/clFFT/pull/52.

[TimmyLiu]

In my linux system (OpenSuse) that I tested, the python files were installed to ${BUILD_DIR}/package/bin directory. "client", which the python scripts will call, resides in the same directory. The architecture of the "package" also includes "lib64", which contains library binary files, "include" with header files and "samples". I am wondering why the pythons scripts were installed into /usr/bin instead.

[marbre]

Actually, this change is similar to https://github.com/clMathLibraries/clFFT/commit/37b1f443e516f0a87c4a728cac8291148bb31b72. See the discussion in https://github.com/clMathLibraries/clFFT/pull/50.

Following your description, it seems that you just compile the package, but didn't installed it. For Gentoo Linux, the change is definitely, necessary. I recently created an clBLAS ebuild for the gentoo science overlay, where the patch already get's applied. Anyway, we always like to see patches getting upstream. Therefore this pull request :)

[TimmyLiu]

I did install the package. But it seems there was a recent pull request #71 that by default will make the install destination a system directory on linux system, which I have mixed feelings about. Setting the top level install destination (CMAKE_INSTALL_PREFIX) from cmake, to a destination of your choice will install all the binaries and scripts there. I wonder if that would be okay with you.

[marbre]

I just build clBLAS from the develop branch.

-- Installing: /var/tmp/portage/sci-libs/clblas-9999/image/usr/bin/clBLAS-client
-- Installing: /var/tmp/portage/sci-libs/clblas-9999/image/usr/bin/testPerfWrapper
-- Installing: /var/tmp/portage/sci-libs/clblas-9999/image/usr/bin/measurePerformance.py
-- Installing: /var/tmp/portage/sci-libs/clblas-9999/image/usr/bin/plotPerformance.py
-- Installing: /var/tmp/portage/sci-libs/clblas-9999/image/usr/bin/blasPerformanceTesting.py
-- Installing: /var/tmp/portage/sci-libs/clblas-9999/image/usr/bin/errorHandler.py
 [..]

The install path /var/tmp/portage/sci-libs/clblas-9999/image/ get's stripped on Gentoo systems in the next step, thus the Python scripts geht installed to /usr/bin.

I also checked pull request #71, this doesn't affect the install location of the python scripts.

[TimmyLiu]

Hi. It sounds like all the binaries were installed correctly to the install path but the python scripts are still installed to /usr/bin, as well as clBLAS-client?

[marbre]

This is only a snipped, not all binaries (examples) get installed to the correct location ( as mentioned in #75 ). Anyway, clBLAS-client get's installed to /usr/bin which is correct, but the python scripts still shouldn't be installed to /usr/bin.

[marbre]

How should we proceed here? I would really like to drop the patches from the clblas ebuild.