search

clade / ThorlabsPM100

26 stars 10 forks source link

Ask is deprecated in pyvisa #6

Closed marcelhohn closed 4 years ago

marcelhohn commented 5 years ago

When using the module I get the following warning from pyvisa's resources/messagebased.py file: 

FutureWarning: ask is deprecated and will be removed in 1.10, use query instead.
  '1.10, use query instead.', FutureWarning)

It would be nice if this module could be adapted accordingly.

bleykauf commented 4 years ago

Looks like this has already been done in https://github.com/clade/ThorlabsPM100/commit/ff9a9ebcf5caf2d585ddadfc5dcbe8ba31e3ac5b but not been pushed to PyPi.

itayperl commented 4 years ago

+1 for updating PyPI. The ask method does not exist anymore in the latest PyVISA master branch, so when they make a release ThorlabsPM100 will break.

clade commented 4 years ago

Pypi is now updated (version 1.2.1)