claraqin / neonMicrobe

Processing NEON soil microbe marker gene sequence data into ASV tables.
GNU Lesser General Public License v3.0
9 stars 4 forks source link

Option to exclude legacy data and other dataQF tags #19

Closed claraqin closed 3 years ago

claraqin commented 4 years ago

There should be some code to allow the user to exclude legacy data and other dataQF tags from the sequence files they download.

In the Technical Working Group meeting on Oct. 5, we discussed doing this with a simple grep command to subset the metadata object. However, there is a planned revision to download files using zipsByURI, which only accepts metadata from a file location, so after this revision is made, slightly more code must be added in order to write the subsetted metadata to file.

I don't have a strong preference between creating a new function for this, versus just producing a few lines of code that we could put into the "Download NEON Data" vignette.

lstanish commented 3 years ago

@claraqin I'm leaning towards including a couple of lines of code in the vignette highlighting these decision points, given that there are numerous options and it's hard to code them all in a clean function. Some of the components to highlight could be:

Thoughts? Suggestions?

lstanish commented 3 years ago

@claraqin Just re-visiting this issue, and I like the idea of having the QC function check the F and R primers. Will add that to the list of QC checks in the QF function GH issue. Is it OK to close this issue?

claraqin commented 3 years ago

Yes, it is! Thanks for taking care of this.