claribelho / pe

0 stars 0 forks source link

Sleep add disallowing today's date should not be the case #5

Open claribelho opened 6 months ago

claribelho commented 6 months ago

User Guide

image.png

image.png

To consider that user's can take naps in the day or they slept in the early hours of the day instead of the night before, it should be allowed to add sleep cycles for today's date. Additionally, there was no indication in the UG that only dates before today's is allowed.

nus-pe-bot commented 6 months ago

Team's Response

This should be a feature flaw of medium severity as we have designed the product to only allow input for dates before the actual day only, however, allowing for actual day inputs will indeed allow for a better sleep tracker and can be implemented in future versions.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I do not believe that this should be considered NotInScope as it is a valid concern that should not be further delayed. Firstly, there was no mention in the User Guide that the product was designed to only allow input for dates before the actual day only. image.png

In fact, even in their Developer Guide's description for sleep, the purpose of this Sleep Tracker was "so that users will know when their lacking sleep or getting more sleep hours as the day progresses." Thus, it would make sense for the user to be able to add sleep cycles for today's date, in order to see this sleep progression throughout the day. image.png

From a user's pov, the ability to input sleep cycles for today's date is extremely important and should be implemented in this version. It makes the most sense for me to use a tracker once I have completed an activity within the day itself else, I would need to remember all sleep cycles I had today to input tomorrow, which is an inconvenience.

I also believe that this will not require much additional effort from the team. The current code is as follows, and the if-statement can simply be changed to check if the dateSlept is after today (thus exception is not thrown for dates before and inclusive of today): if (dateSlept.isAfter(LocalDate.now())) { ...} image.png

Hence, I would not consider this NotInScope.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** As mentioned in the previous disagreement, from a user's pov, the ability to input sleep cycles for today's date is extremely important. It makes the most sense for me to use a tracker once I have completed an activity within the day itself else, I would need to remember all sleep cycles I had today to input tomorrow, which is an inconvenience. Thus, for users using this sleep tracker, I would say that it will affect most users and does cause major problems for users since i essentially, am unable to use this sleep feature for today's tracking until the next day.