clarissatjx / pe

0 stars 0 forks source link

Storage file does not save #5

Open clarissatjx opened 2 weeks ago

clarissatjx commented 2 weeks ago

Steps to reproduce:

  1. Ensure there is no data file

Screenshot 2024-11-15 at 4.58.19 PM.pngScreenshot 2024-11-15 at 4.58.19 PM

  1. Launch the app

Screenshot 2024-11-15 at 4.57.44 PM.pngScreenshot 2024-11-15 at 4.57.44 PM

  1. Close the app by clicking on the close button (not typing 'exit')

There is no data folder after closing the app. but when I click 'exit' the data file is saved. This could cause some issues with data not being saved though it is dummy data when the app first launches. Hence, this issue is marked as severity medium.

nus-pe-script commented 1 week ago

Team's Response

Firstly, If changes are made to the sample data (via user commands), the new data will be saved in the created data file.

Secondly, If no changes are made to the sample data, the sample data will still remain the next time the user opens the app and no data file is created, this is expected behaviour. Steps to reproduce:

  1. Download BridalBuddy jar file
  2. Launch the app -> You should see the sample data
  3. Close the app
  4. Reopen the app -> The sample data is still there. No data loss is observed

    Items for the Tester to Verify

    :question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree as I could not reproduce what the team said. When I first launched the app (aka, very first time using the app), there is dummy data loaded up in the app. However, when I close the app by clicking on the top left red button (and not typing in /exit), there is no data file (aka bridalbuddy.json). As I mentioned in the original post, 'This could cause some issues with data not being saved though it is dummy data when the app first launches.' However, I will agree with the severity lowered to Low instead of Medium.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]