search

clarity-h2020 / map-component

The Map Component is a reusable, flexible and highly configurable Building Block meant to be used throughout CSIS.
https://csis.myclimateservice.eu/
1 stars 1 forks source link

Improve Edit-Mode of Study Area Map #87

Closed p-a-s-c-a-l closed 4 years ago

p-a-s-c-a-l commented 4 years ago

For the user, it's not obvious, that edit mode is activated as reported here. Here at least the title of the "Toggle Edit" Button should change when in edit mode. Furthermore, the EMIKAT calculation is trigged, once the BBOX has been drawn. Instead, it should be trigged only when edit mode is deactivated again.

When in edit mode, 2 buttons should be shown: Cancel Edit and Save Changes. Only when pressing Save Changes, a (re-)calculation should be triggered.

Additionally, we should 1) either forbid editing if a bounding box is already set, thus effectively forbid re-calculations at all (see https://github.com/clarity-h2020/emikat/issues/34#issuecomment-595674938) 2) or show a warning to the user that when pressing Save Changes the study is re-calculated.

patrickkaleta commented 4 years ago

See this update for the new Emikat calculation trigger mechanics.

therter commented 4 years ago

The buttons Cancel Edit and Save Changes will be shown now, when the edit mode was started.

therter commented 4 years ago

The trigger was updated and the study area map was updated, so this issue can be closed