clarkbw / jest-webextension-mock

A module to mock WebExtensions in Jest

BSD 3-Clause "New" or "Revised" License

93 stars 37 forks source link

Feat/158 get manifest final #160

Closed escapedcat closed 2 years ago

escapedcat commented 2 years ago

See #159

escapedcat commented 2 years ago

Meh, I'm confused. Did this work before?
Look slike this is the last one which turned green?: https://github.com/clarkbw/jest-webextension-mock/pull/127

Is it a settings thing?

clarkbw commented 2 years ago

I've checked the settings. Everything is fine and I haven't changed anything. Lemme reach out to GitHub support.

clarkbw commented 2 years ago

https://github.com/clarkbw/jest-webextension-mock/pull/152 was the last PR to be merged

escapedcat commented 2 years ago

Ugh, I'm sorry!
I encountered this with checks running via circle-ci before. Those only run if the contributor has a cricle-ci account. Doesn't help here :(

clarkbw commented 2 years ago

Filed https://support.github.com/ticket/personal/0/1888685 and we'll see what happens. Thanks for reopening this PR! Hopefully the original will work once they figure it out.

escapedcat commented 2 years ago

Ah,

dependabot PR went into master

This one shoudl go into clarkbw:main

But actiosn are only triggered via master?:
https://github.com/clarkbw/jest-webextension-mock/blob/main/.github/workflows/push.yml#L3-L7

Bit confused by what's the current default branch I guess. Mayeb just editing the action helps? Not sure if I can do this but I can try.

escapedcat commented 2 years ago

Yay! 🎉

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c2f113a). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #160 +/- ## ======================================= Coverage ? 99.50% ======================================= Files ? 14 Lines ? 202 Branches ? 43 ======================================= Hits ? 201 Misses ? 1 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

escapedcat commented 2 years ago

I guess that's why we didn't dare to switch from master to main on commitlint yet 😿

clarkbw commented 2 years ago

OMG

escapedcat commented 2 years ago

🤝 thanks!

clarkbw commented 2 years ago

https://www.npmjs.com/package/jest-webextension-mock/v/3.8.0