search

claunia / plist-cil

C#/.NET parser for Apple and GnuStep Property List (aka plist), based on Java's dd-plist
Other
54 stars 17 forks source link

Fix building plist-cil #30

Closed qmfrederik closed 6 years ago

qmfrederik commented 6 years ago

I got a couple of errors when building from source, and this PR tries to address them:

  1. To get System.Linq on .NET 4.0 and .NET 4.5, you need to add a reference to `System.Core. This PR adds that reference
  2. I got a couple of errors because BitConverter.GetBytes(x).Reverse().ToArray() was being used. This PR changes that to be: this.bytes = BitConverter.GetBytes(x); Array.Reverse(this.bytes). This has the advantage of using Array.Reverse, which should be a bit more performant too (as no new array is being allocated).
  3. The AppVeyor script was slightly outdated, this fixes that.
  4. Add support for netcoreapp2.0 and netstandard2.0
  5. Skip the TestIssue30 test (see 3breadt/dd-plist@e6cc1a0a171ed49577254a2dcd3c9d52aa0253ea) as thsi functionality is not yet implemented
  6. The new csproj file format is supported by Mono 5.x and newer, so update the .travis-ci.yml file to reflect that.
qmfrederik commented 6 years ago

@claunia OK it took a while to get thing green 😄 , but the builds are now passing on AppVeyor and Travis. Could you perhaps have a quick look at this and let me know whether this is good to merge?

claunia commented 6 years ago

Ok sounds good, thx!

qmfrederik commented 6 years ago

Thanks, I've rebased the other PRs on master, should make it easier to review them 😄 .