[BUG] hyphen in name break wallet import on android (not checked on iphone)

[JoAnnGar]

Covid cert does not display my name and details in two of the suggested android apps. Is anyone working on a more reliable android app?

[github-actions[bot]]

Hey there 👋🏼 Thanks for your first issue. This is an automated message but a real human will handle your issue very shortly.

[clawfire]

Hi @JoAnnGar 😃 What wallet app on Android did you tried? I'm using Stocard myself, and it's working pretty well, but I can't try with all names combinations. Do you have a long name or non-latin characters in it?

[JoAnnGar]

I do have one non-letter in my name - a hyphen. I tried stocard which did not recognize it as a cert so it just stored the qr code. Then I tried the wallet one and the results were again not showing any of my details - not dates, type of vaccine and name was missing too.

On Thu, Jul 15, 2021, 20:10 Thibault Milan @.***> wrote:

Hi @JoAnnGar https://github.com/JoAnnGar 😃 What wallet app on Android did you tried? I'm using Stocard myself, and it's working pretty well, but I can't try with all names combinations. Do you have a long name or non-latin characters in it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clawfire/covid19-passbook-generator/issues/62#issuecomment-880945023, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5M5SIUL3LV5CP4WZIWKQTTX4XA3ANCNFSM5AN46QAQ .

[clawfire]

Oh that's interesting. I just finished working on #60 for non-latin characters but I need to check those hyphen issue. Thanks a lot for bringing it up !

[clawfire]

I just tried with a testing pass that has a hyphen in the name and it works as you can see attached

If you feel comfortable, could you send me a screenshot of your QR code at hello@thibaultmilan.com so I can try to understand where it fails? If not, don't worry. It's private information and I respect that 😃 that's why I built that app collecting 0 data about users at first 😄

[JoAnnGar]

Which app is that?

On Thu, Jul 15, 2021, 21:27 Thibault Milan @.***> wrote:

I just tried with a testing pass that has a hyphen in the name and it works as you can see attached [image: Screenshot_20210715-222412] https://user-images.githubusercontent.com/1178/125852851-5a18ea70-d923-4b59-acbf-bd02cd00b8db.png

If you feel comfortable, could you send me a screenshot of your QR code at @.*** so I can try to understand where it fails? If not, don't worry. It's private information and I respect that 😃 that's why I built that app collecting 0 data about users at first 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clawfire/covid19-passbook-generator/issues/62#issuecomment-880991358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5M5SKBDYC2GQA3KA7ZROTTX5AD3ANCNFSM5AN46QAQ .

[clawfire]

It's Stocard

[JoAnnGar]

Very odd that it works for you and not for me on that exact same app!

On Fri, Jul 16, 2021 at 8:46 AM Thibault Milan @.***> wrote:

It's Stocard https://play.google.com/store/apps/details?id=de.stocard.stocard&hl=fr&gl=US

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clawfire/covid19-passbook-generator/issues/62#issuecomment-881247068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5M5SOG3BUAM4F6M5VYWE3TX7PTVANCNFSM5AN46QAQ .

-- Kind regards

Jo-Ann

https://www.linkedin.com/in/joanngarbutt https://www.linkedin.com/in/joanngarbutt

[image: --]

https://about.me/jgarbutt?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links

[clawfire]

Well I didn't tried with your QR Code. Maybe there's something elsewhere than your name that make it crash. I'll check with yours later the weekend

[clawfire]

Hey, thanks for your code. Okay, so I can confirm your code isn't correctly generated by your authority, and checking the app for at least Luxembourg, France, and Switzerland rejects it. That explains why my application doesn't work either. Your QR code is just not valid at all :(

[JoAnnGar]

My code is from Ireland, I guess they did not align with the rest of europe then. 😬

On Sun, Jul 18, 2021, 00:53 Thibault Milan @.***> wrote:

Hey, thanks for your code. Okay, so I can confirm your code isn't correctly generated by your authority, and checking the app for at least Luxembourg, France, and Switzerland rejects it. That explains why my application doesn't work either. Your QR code is just not valid at all :(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clawfire/covid19-passbook-generator/issues/62#issuecomment-881975257, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5M5SMIMG4JMUFP5THOXNTTYIJV3ANCNFSM5AN46QAQ .

[clawfire]

Oh, I was misled by the 🇮🇹 flag on the screenshot you sent me. Well, I had a lot of 🇮🇪 users the last few days and few bug reports. Sorry that happen to you