search

clawpack / pyclaw

PyClaw is a Python-based interface to the algorithms of Clawpack and SharpClaw. It also contains the PetClaw package, which adds parallelism through PETSc.
http://www.clawpack.com/pyclaw
BSD 3-Clause "New" or "Revised" License
164 stars 99 forks source link

Skip shallow water on the sphere test on Github to avoid segfault. #736

Closed ketch closed 1 month ago

ketch commented 1 month ago

This is hopefully temporary, and will allow us to get coverage working again. Coverage currently doesn't work because this test crashes the whole process. See #735.

ketch commented 1 month ago

I'm going to go ahead and merge this since the tests pass, so that we can continue work on #735.

pavelkomarov commented 1 month ago

Why when I run locally do I not have a shallow water segfault, but I do get a failure on one the advection tests?

FAILED examples/advection_1d_variable/test_variable_coefficient_advection.py::TestAdvectionVarCoeff1D::test_sharpclaw_custom_time_integrator - AssertionError: Failed for SSP33

Are these tests just numerically brittle or something? They should be robust to different systems/environments. I think this merits its own issue, if one doesn't already exist for this problem.