search

cleanflight / cleanflight-configurator

Google chrome/chromium based configuration tool for the cleanflight firmware
GNU General Public License v3.0
332 stars 250 forks source link

Added dynamic notch filter as a feature to the configuration tab #500

Closed McGiverGim closed 7 years ago

McGiverGim commented 7 years ago

Added the DYNAMIC_NOTCH feature as a feature in the configuration tab.

More info: https://github.com/betaflight/betaflight/pull/3074

McGiverGim commented 7 years ago

One thing to this PR: I thinked that it will be better to put the switch in the PIDs tab, inside the FILTERS tab, and not in the general configuration tab but if I'm not wrong, the "SAVE" button must be changed to a "SAVE AND REBOOT" so I thinked that this is not a good idea. Am I wrong?

McGiverGim commented 7 years ago

I've seen that a similar code was included in BF along with others: https://github.com/betaflight/betaflight-configurator/pull/545 So maybe better close this PR and cherry pick from them.

Sent from my Google Nexus 5X using FastHub