clear-code / statistics

Statistics of ClearCode Inc. activity
Other
0 stars 2 forks source link

firefox: processのtypoがある #90

Closed kenhys closed 6 years ago

kenhys commented 6 years ago

Problem

システムアドオンをみていて見つけたやつ。 processのtypoが散見される。

Expected

typoが修正されていること。 proces ではなく process

Actual

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_processing/echo_control_mobile_unittest.cc#22

// TODO(peah): Increase the number of frames to proces when the issue of
// non repeatable test results have been found.
const int kNumFramesToProcess = 200;

https://dxr.mozilla.org/mozilla-central/source/security/sandbox/chromium/sandbox/win/src/crosscall_server.h#208

 // Called when a target proces is created, to setup the interceptions related
  // with the given service (IPC).
  virtual bool SetupService(InterceptionManager* manager, int service) = 0;

https://dxr.mozilla.org/mozilla-central/source/browser/extensions/webcompat/bootstrap.js#67

 // Listen to the useragentoverrides-initialized notification we get and
  // initialize our overrider there. This is done to avoid slowing down the
  // apparent startup proces, since we avoid loading anything before the first
  // window is visible to the user. See bug 1371442 for details.
  let startupWatcher = {
okkez commented 6 years ago

https://developer.mozilla.org/ja/docs/Mozilla/Developer_Guide/Source_Code

ここらへんを見ると進められそう。

okkez commented 6 years ago

ファイル名とか関数名でもprocesになっているところがあるので、全部一括で直すのはまずそう。 もしかして、Firefoxの中ではそういう使い方なんだろうか?

$ ag proces\\b
browser/extensions/webcompat/bootstrap.js
65:  // apparent startup proces, since we avoid loading anything before the first

gfx/thebes/gfxPlatform.cpp
629:    // Only increase memory on the content proces

security/nss/cmd/modutil/install.c
13:#include <prproces.h>

security/sandbox/chromium/sandbox/win/src/crosscall_server.h
208:  // Called when a target proces is created, to setup the interceptions related

third_party/python/psutil/HISTORY.rst
727:- 634_: [Linux] Proces.cmdline() does not include empty string arguments.

third_party/rust/bzip2-sys/bzip2-1.0.6/manual.ps
62457:(preproces) 38.7246 Tj

extensions/auth/nsAuthSambaNTLM.h
13:#include "prproces.h"

extensions/spellcheck/hunspell/tests/unit/data/suggestiontest/List_of_common_misspellings.txt
2868:proces     process

toolkit/xre/nsUpdateDriver.cpp
17:#include "prproces.h"

toolkit/xre/nsUpdateDriver.h
25:#include "prproces.h"

toolkit/xre/nsAppRunner.cpp
49:#include "prproces.h"

toolkit/components/telemetry/Telemetry.cpp
12:#include <prproces.h>

dom/payments/PaymentRequestManager.h
26: *  It is also the communication agent to chrome proces.

config/system-headers.mozbuild
687:    'prproces.h',

config/external/nspr/pr/moz.build
160:        '/nsprpub/pr/src/md/unix/uxproces.c',
230:    '/nsprpub/pr/include/prproces.h',

netwerk/srtp/src/include/ekt.h
149:srtp_err_status_t srtp_ekt_tag_verification_preproces(uint8_t *pkt_tag,
153:srtp_err_status_t srtp_ekt_tag_verification_postproces(uint8_t *pkt_tag,

xpcom/threads/nsProcess.h
24:#include "prproces.h"

xpcom/io/nsLocalFileWin.cpp
42:#include "prproces.h"

xpcom/io/nsLocalFileUnix.cpp
46:#include "prproces.h"

media/webrtc/trunk/webrtc/modules/audio_processing/echo_control_mobile_unittest.cc
22:// TODO(peah): Increase the number of frames to proces when the issue of

nsprpub/pkg/solaris/SUNWprd/prototype
70:f none usr/include/mps/prproces.h 0644 root bin

nsprpub/pr/tests/parent.c
14:#include "prproces.h"

nsprpub/pr/tests/sockping.c
22:#include "prproces.h"

nsprpub/pr/tests/pipeping2.c
22:#include "prproces.h"

nsprpub/pr/tests/pipeping.c
23:#include "prproces.h"

nsprpub/pr/tests/exit.c
10:#include "prproces.h"

nsprpub/pr/src/md/unix/Makefile.in
19:     uxproces.c \

nsprpub/pr/src/md/unix/objs.mk
12:     uxproces.c \

nsprpub/pr/include/nspr.h
31:#include "prproces.h"

nsprpub/pr/include/prshma.h
104:#include "prproces.h"

nsprpub/pr/include/md/_beos.h
12:#include "prproces.h"
piroor commented 6 years ago

https://dxr.mozilla.org/mozilla-central/search?q=proces++-process+-prproces+-uxproces+-path%3Athird_party+-file%3Afeed+-file%3Adictionary+-file%3Adic&redirect=false

だいぶ絞り込んだ。まだいくつか関数名があるが、それを除けばこれでいける?

piroor commented 6 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1457395 Bugzillaに起票したのでこちらは閉じます。