clearcontainers / runtime

OCI (Open Containers Initiative) compatible runtime using Virtual Machines
Apache License 2.0
589 stars 70 forks source link

logging: Add CLI command to logs #1025

Closed jodh-intel closed 6 years ago

jodh-intel commented 6 years ago

Since the runtime is called multiple times by the container manager, add the command-line sub-command name to all log entries to make it clear which command was running when a particular log message was produced.

Note that CLI arguments are already logged once at runtime startup. This change is more useful for the scenarios where only a log excerpt is available (for example when running cc-collect-data.sh which only extracts error logs).

Fixes #1024.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

jodh-intel commented 6 years ago

@grahamwhaley - no it doesn't. That should be atleast partly possible in a follow-on PR.

devimc commented 6 years ago

lgtm

Approved with PullApprove Approved with PullApprove