Closed jodh-intel closed 6 years ago
I'd say option 2 since I don't like that we have to mount the image so that we can find the agent version from cc-runtime.
cc-collect-data.sh
is a separate script, which might be more appropriate for this specific mounting operation.
Sounds reasonable. I'll update the script...
As mentioned https://github.com/clearcontainers/tests/issues/944#issuecomment-371157669, the runtime does not display the agent version, although the output of
cc-env
suggests it should/tries to:The best strategy would seem to be to bind-mount the image (using
losetup
+mount
) and runcc-agent --version
now that https://github.com/clearcontainers/agent/pull/213 has landed.The question though is where we should run this:
In the runtime
This would allow the
cc-env
output to display the correctAgent.Version=
.In
cc-collect-data.sh
If we do this, we need to remove the
Agent.Version=
from the runtime.Option (1) seems logical but is a bit... brace yourself for a very technical term... "yucky". That said:
cc-check
callsmodinfo(8)
.wdyt @sboeuf, @sameo, @grahamwhaley, @mcastelino? Should we take a vote on this? :smile: