clearcontainers / runtime

OCI (Open Containers Initiative) compatible runtime using Virtual Machines
Apache License 2.0
589 stars 70 forks source link

cc-check: Use nanosecond timestamps when stderr is redirected #1075

Closed jodh-intel closed 6 years ago

jodh-intel commented 6 years ago

For consistency with all other timestamps, change cc-check to use nanosecond timestamps when stderr is not a terminal.

Fixes #1074.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

jodh-intel commented 6 years ago

The metrics CI hit the dreaded dpkg "Hash Sum mismatch" mirror error. Restarting...

jodh-intel commented 6 years ago

logrus squirts its output to stderr by default. But when stderr is not a terminal, it switches mode to disable colour.

See the top of https://github.com/sirupsen/logrus (the first colour image and the two text blocks below it.

devimc commented 6 years ago

lgtm

Approved with PullApprove Approved with PullApprove