search

clearlinux / clr-boot-manager

Kernel & Boot Loader Management
https://clearlinux.org/
111 stars 30 forks source link

Add support for non-ext filesystems #238

Closed silkeh closed 3 years ago

silkeh commented 4 years ago

Calling stat() on some filesystems, like Btrfs, results in a dev_t with no relation to the backing device(s), and subsequent failure to detect the root fs.

Add support such filesystems by retrieving the block device from /proc/self/mounts and working on from there.

Resolves #61, #182 and #193.

karthikprabhuvinod commented 4 years ago

@silkeh Out of curiosity, were you trying to use for Solus?

silkeh commented 4 years ago

Yes, I am using this on my Solus install (with an additional patch for the rootflags that I will PR later).

ElXreno commented 3 years ago

This PR still unreviewed after a long time. Is there a reason for that?

silkeh commented 3 years ago

This PR still unreviewed after a long time. Is there a reason for that?

My guess is that it has to do with the new direction of the Clear Linux project (which killed off official desktop support). Not sure why the boot manager is also affected by this, but looking at the profiles of @dorileo and @karthikprabhuvinod (and the other clearlinux repos) it seems that Intel stopped sponsoring development somewhere between May and July of 2020.

ahkok commented 3 years ago

This actually looks really good. I suppose we should run this through our own tests and make sure it works ok. I known @mdhorn might want to do this, or else @phmccarty maybe?