search

clearlinux / swupd-client

Software update client
Other
116 stars 62 forks source link

Paths should be configurable and shouldn't assume Clear Linux conventions #67

Open incandescant opened 8 years ago

incandescant commented 8 years ago

To help ease adoption on non-Clear Linux distributions paths which are currently hard-coded (and defaulting to Clear Linux conventions) should be easily overridden.

The following hard-coded paths are hard-coded to match Clear Linux conventions in swupd-client 3.5.3:

Several other paths are hardcoded, but with slightly less unusual defaults, including:

barbieri commented 8 years ago

would --with-bundles-dir=PATH to replace BUNDLES_DIR be enough? This is easy to do in configure.ac

phmccarty commented 8 years ago

Yes, I think adding --with-* options would be best. For the defaults, I also want to change the "clear" path components to "swupd" instead.

barbieri commented 8 years ago

if you're going to move to swupd then it doesn't make sense to change the defaults I'd say. The confusion at the moment is we have clear in a context that doesn't mean anything. If it was /usr/share/swupd/bundles, it would be immediate to associate that to swupd.

Do you have an idea when you want to move these defaults?

incandescant commented 8 years ago

I agree that --with-* options would be best. I think there is value in both having sane defaults (/usr/share/swupd/bundles) and allowing the defaults to be overridden (it's entirely possible to build an OS where datadir isn't /usr/share).

I'm happy to patch configure.ac in-line with the discussion here and submit a PR.

phmccarty commented 8 years ago

@incandescant Sure, feel free to submit a fix for this.

pohly commented 7 years ago

/usr/share/clear/versionstamp as used by swupd's verifytime command is another convention from Clear which should be configurable.

phmccarty commented 7 years ago

Yes, agreed.