search

clearpathrobotics / robot_upstart

ROS package of helper functions related to bringing up roslaunch on system startup.
BSD 3-Clause "New" or "Revised" License
196 stars 96 forks source link

Make tests pass on ROS 2 #124

Closed civerachb-cpr closed 2 months ago

civerachb-cpr commented 2 months ago

Tested on Jazzy. Tests are now passing (on my machine at least). Necessary changes:

  1. Add test.launch/*.launch to the installed files; otherwise the Job object cannot locate the launch files to install
  2. Replace check for upstart configuration file with newer systemd configuration file

I'd appreciate someone running the tests on different machines and different ROS distributions to make sure the changes work on those too before we release an updated version.

General testing process:

cd /path/to/workspace
rm -rf install/robot_upstart
colcon build --packages-select robot_upstart
colcon test --packages-select robot_upstart
cat log/latest_test/robot_upstart/stdout.log

Make sure the log doesn't show any assertion failures. Assuming there aren't any we should be in good shape.