clearpathrobotics / robot_upstart

ROS package of helper functions related to bringing up roslaunch on system startup.
BSD 3-Clause "New" or "Revised" License
196 stars 96 forks source link

Adding a --wait flag to launch file to the install script #72

Closed msadowski closed 5 years ago

msadowski commented 6 years ago

Hi!

This might be slightly tangential to #16. I noticed that the only clean way to add a --wait flag to the launch file is through the python API?

In a system with multiple machines and a single master it might be desired to wait for the master to start launchfiles (otherwise a launch will not be successful if it's execute before master comes up).

I'm more than happy to try to add this feature and make a PR if you think it's desired.

130s commented 5 years ago

I think this is addressed already by https://github.com/clearpathrobotics/robot_upstart/pull/73

msadowski commented 5 years ago

Yes it is, closing it!