cleder / pygeoif

Basic implementation of the __geo_interface__ 🌐️
https://pygeoif.readthedocs.io
67 stars 27 forks source link

170 modernize packaging #174

Closed cleder closed 1 year ago

cleder commented 1 year ago

workerB

watermelon-copilot-for-code-review[bot] commented 1 year ago

WatermelonAI Summary

The three commits in this PR tell us that the focus is on modernizing the packaging of the project. Commit 1 suggests the use of keyword arguments for improved readability and maintainability. Commit 2 indicates the implementation of per file ignores for flake8, a static code analysis tool, in order to improve the code quality. Commit 3 adds a codecov token, which suggests an emphasis on code coverage and testing. Overall, these changes aim to make the project's packaging more up-to-date and efficient.

GitHub PRs

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c60c834) 100.00% compared to head (c8420ff) 100.00%. Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #174 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 21 21 Lines 2244 2244 ========================================= Hits 2244 2244 ``` | [Files](https://app.codecov.io/gh/cleder/pygeoif/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann) | Coverage Δ | | |---|---|---| | [pygeoif/factories.py](https://app.codecov.io/gh/cleder/pygeoif/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann#diff-cHlnZW9pZi9mYWN0b3JpZXMucHk=) | `100.00% <100.00%> (ø)` | | | [pygeoif/feature.py](https://app.codecov.io/gh/cleder/pygeoif/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann#diff-cHlnZW9pZi9mZWF0dXJlLnB5) | `100.00% <ø> (ø)` | | | [pygeoif/functions.py](https://app.codecov.io/gh/cleder/pygeoif/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann#diff-cHlnZW9pZi9mdW5jdGlvbnMucHk=) | `100.00% <100.00%> (ø)` | | | [pygeoif/geometry.py](https://app.codecov.io/gh/cleder/pygeoif/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann#diff-cHlnZW9pZi9nZW9tZXRyeS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

what-the-diff[bot] commented 1 year ago

PR Summary

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/cleder/pygeoif/174/8eed4272/c8420ff12c3aa34ac37d270ffdabd0d915c39dd3.svg)](https://app.codesee.io/r/reviews?pr=174&src=https%3A%2F%2Fgithub.com%2Fcleder%2Fpygeoif) #### Legend CodeSee Map legend