cleder / pygeoif

Basic implementation of the __geo_interface__ 🌐️
https://pygeoif.readthedocs.io
67 stars 27 forks source link

move_coordinates supports generators (Sourcery refactored) #189

Closed sourcery-ai[bot] closed 1 year ago

sourcery-ai[bot] commented 1 year ago

Pull Request #188 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/cleder/pygeoif pull/188/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

watermelon-copilot-for-code-review[bot] commented 1 year ago

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

pep8speaks commented 1 year ago

Hello @sourcery-ai[bot]! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2023-11-12 22:08:56 UTC
watermelon-copilot-for-code-review[bot] commented 1 year ago

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

what-the-diff[bot] commented 1 year ago

PR Summary

watermelon-copilot-for-code-review[bot] commented 1 year ago

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ff2e39c) 100.00% compared to head (3f58c5e) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #189 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 21 21 Lines 2412 2430 +18 ========================================= + Hits 2412 2430 +18 ``` | [Files](https://app.codecov.io/gh/cleder/pygeoif/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann) | Coverage Δ | | |---|---|---| | [pygeoif/functions.py](https://app.codecov.io/gh/cleder/pygeoif/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann#diff-cHlnZW9pZi9mdW5jdGlvbnMucHk=) | `100.00% <100.00%> (ø)` | | | [tests/test\_functions.py](https://app.codecov.io/gh/cleder/pygeoif/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann#diff-dGVzdHMvdGVzdF9mdW5jdGlvbnMucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/cleder/pygeoif/189/3a54067a/3f58c5e0ca3916da4522ff36a40a8370aac14111.svg)](https://app.codesee.io/r/reviews?pr=189&src=https%3A%2F%2Fgithub.com%2Fcleder%2Fpygeoif) #### Legend CodeSee Map legend