cleidigh / printing-tools-ng

PrintingTools NG Thunderbird Extension - Printing Utilities
Other
36 stars 17 forks source link

Inline images incorrectly added to header attachments list #275

Open cleidigh opened 2 weeks ago

cleidigh commented 2 weeks ago

In v128+, the messages.getAttachmentsList api returns inline images . This changed from v115.

The contentId property appears to be an indirect way to determine and filter inline images. Need to also check signature files @cleidigh

rosasprint commented 2 weeks ago

Chris Thank you for dealing with this matter.

cleidigh commented 2 weeks ago

@rosasprint Thanks for jumping onto Github, can't debug on reviews ;-}

I think I have this fixed. Go to my maintenance release issue for v3.1.1 here:

Download and install from the addons tab. Under gear icon is Install addon from file.

@cleidigh

rosasprint commented 2 weeks ago

@cleidigh Thank you for your message. I installed and tested printing-tools-ng-3.1.1-b1-tb.xpi. Thanks to you, inline images no longer appear as attachments in the print header.

Your quick response helped me a lot. Thank you very much.

cleidigh commented 2 weeks ago

@rosasprint Great! Thanks for doing a positive review despite having an issue. Frequently users post lousy reviews without giving any opportunity to address. @cleidigh